Tests enhancement

tests/Makefile.am

@@ -1,6 +1,6 @@
-TESTS = ttail_init_check
-check_PROGRAMS = ttail_init_check
+TESTS = ttail_argparse_check
+check_PROGRAMS = ttail_argparse_check
 
-ttail_init_check_SOURCES = ttail_init_check.c
-ttail_init_check_CFLAGS = @CHECK_CFLAGS@
-ttail_init_check_LDADD =  $(top_builddir)/src/libttail.a @CHECK_LIBS@
+ttail_argparse_check_SOURCES = ttail_argparse_check.c
+ttail_argparse_check_CFLAGS = @CHECK_CFLAGS@
+ttail_argparse_check_LDADD =  $(top_builddir)/src/libttail.a @CHECK_LIBS@

tests/ttail_argparse_check.c

@@ -1,8 +1,16 @@
 #include <check.h>
+#include <errno.h>
+#include <stdio.h>
+#include <unistd.h>
 
-#include "../src/include/ttail.h"
+
+#include "ttail.h"
 
 ttail_t *ttail;
+#define __Fname_sz 5
+#define FNAME_NO_EXIST 0
+#define FNAME_EXIST 1
+char *fname[__Fname_sz];
 
 void teardown_ttail(void)
 {
@@ -56,11 +64,54 @@ END_TEST
  * file argument parsing
  */
 
-START_TEST (test_init_file_non_exist)
+void setup_fname(void)
+{
+	int i;
+	FILE *fp;
+	for(i=0;i<__Fname_sz;i++)
+	{
+		fname[i] = NULL;
+	}
+
+	for(i=0; i<__Fname_sz; i++)
+	{
+		fname[i] = tempnam(NULL, "ttail_check");
+		if(i%2)
+		{
+			if((fp=fopen(fname[i], "w+")) == NULL)
+			{
+				perror("Unable to create file for testing");
+				ck_abort_msg("Unable to create file for testing");
+			} else { printf("Created : %s\n", fname[i]);}
+			if(fclose(fp))
+			{
+				perror("Unable to close file for testing");
+				ck_abort_msg("Unable to close file for testing");
+
+			}
+		}
+	}
+}
+
+void teardown_fname(void)
+{
+	int i;
+	for(i=0; i<__Fname_sz; i++)
+	{
+		unlink(fname[i]);
+		if(fname[i] != NULL)
+		{
+			free(fname[i]);
+		}
+	}
+}
+
+START_TEST (test_argparse_file_non_exist)
 {
 	ttail_t *t;
-	char *args[3] = {"foo", "-f", "__non__existing__"};
+	char *args[3] = {"foo", "-f", NULL};
 
+	args[2] = fname[FNAME_NO_EXIST];
 	t = ttail_init(3, args);
 
 	ck_assert_msg(t->logfile_sz == 1,
@@ -75,15 +126,73 @@ START_TEST (test_init_file_non_exist)
 }
 END_TEST
 
+START_TEST (test_argparse_file_exist)
+{
+	ttail_t *t;
+	char *args[3] = {"foo", "-f", NULL};
+
+	args[2] = fname[FNAME_EXIST];
+
+	t = ttail_init(3, args);
+
+	ck_assert_msg(t->logfile_sz == 1,
+		"ttail_t.logfile_sz should be 1");
+	ck_assert_msg(strcmp(t->logfile_name[0], args[2]) == 0,
+		"ttail_t.logfile_name[0] does not contain the filename");
+	ck_assert_msg(t->logfile[0] != NULL,
+		"ttail_t.logfile[0] shouldn't be NULL");
+	
+	ttail_free(t);
+
+}
+END_TEST
+
+START_TEST (test_argparse_file_multiple)
+{
+	printf("MULTIPLE\n");
+	ttail_t *t;
+	int i;
+	char *args[11] = {"foo", "-f", NULL, "-f", NULL,
+		"-f", NULL, "-f", NULL, "-f", NULL};
+	
+	for(i=0; i<__Fname_sz; i++)
+	{
+		args[(i*2)+2] = fname[i];
+	}
+
+	t = ttail_init(11, args);
+	
+	ck_assert_msg(t->logfile_sz == __Fname_sz,
+		"ttail_t.logfile_sz doesn't have the good value");
+
+	for(i=0;i<__Fname_sz; i++)
+	{
+		ck_assert_msg(strcmp(t->logfile_name[i], args[(i*2)+2]) == 0,
+			"some filename corrupted in ttail_t.logfile_name");
+		if(i%2)
+		{
+			ck_assert_msg(t->logfile[i] != NULL,
+				"logfile not opened");
+		} else {
+			ck_assert_msg(t->logfile[i] == NULL,
+				"logfile should be NULL");
+
+		}
+	}
+
+	
+}
+END_TEST
+
 Suite * ttail_init_suite(void)
 {
 	Suite *s;
 	TCase *tc_argparse_empty;
-	TCase *tc_init_files;
+	TCase *tc_argparse_files;
 
-	s = suite_create("ttail init methods tests");
+	s = suite_create("ttail argument parsing checks");
 
-	tc_argparse_empty = tcase_create("Empty arguments parsing");
+	tc_argparse_empty = tcase_create("empty arguments parsing");
 	tcase_add_checked_fixture(tc_argparse_empty,
 		setup_ttail_empty, teardown_ttail);
 	tcase_add_test(tc_argparse_empty, test_argparse_empty_logfilename);
@@ -93,10 +202,14 @@ Suite * ttail_init_suite(void)
 	tcase_add_test(tc_argparse_empty, test_argparse_empty_fmt);
 	tcase_add_test(tc_argparse_empty, test_argparse_empty_verbose);
 
-	tc_init_files = tcase_create("files options handling");
-	tcase_add_test(tc_init_files, test_init_file_non_exist);
+	tc_argparse_files = tcase_create("files options parse");
+	tcase_add_checked_fixture(tc_argparse_files,
+		setup_fname, teardown_fname);
+	tcase_add_test(tc_argparse_files, test_argparse_file_non_exist);
+	tcase_add_test(tc_argparse_files, test_argparse_file_exist);
+	tcase_add_test(tc_argparse_files, test_argparse_file_multiple);
 
-	suite_add_tcase(s, tc_init_files);
+	suite_add_tcase(s, tc_argparse_files);
 	suite_add_tcase(s, tc_argparse_empty);
 	return s;
 }
@@ -107,6 +220,7 @@ int main(void)
 	SRunner *sr;
 
 	sr = srunner_create(ttail_init_suite());
+	srunner_set_fork_status(sr, CK_FORK);
 
 	srunner_run_all(sr,CK_VERBOSE);
 	number_failed = srunner_ntests_failed(sr);

tests/ttail_init_check.h

@@ -1,3 +0,0 @@
-#include <check.h>
-
-Suite * ttail_init_suite(void);