From 42457370ba2586f76e5ba56d833a52b5b4e1f9bd Mon Sep 17 00:00:00 2001 From: Yann Weber Date: Mon, 15 May 2017 18:41:52 +0200 Subject: [PATCH] Enhancement in option parsing errors Telling getopt to produce an error message by setting opterr to 1 --- src/ttail_init.c | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/src/ttail_init.c b/src/ttail_init.c index 8c368fc..2fb5dbd 100644 --- a/src/ttail_init.c +++ b/src/ttail_init.c @@ -65,7 +65,7 @@ ttail_t *ttail_init(int argc, char **argv) goto ttail_init_alloc_err; } - opterr = 0; + opterr = 1; optind = 0; res->verbose = 0; res->fmt = NULL; @@ -151,13 +151,8 @@ given\n"); strcpy(date, optarg); dates[c=='d'?0:1] = date; break; - case '?': - optind--; - goto init_badarg; - break; - default: - fprintf(stderr, "Bad argument\n"); - goto init_badarg; + default: /* ? */ + goto ttail_init_err; } } @@ -177,8 +172,6 @@ given\n"); } return res; - init_badarg: - fprintf(stderr, "Unknown option '%s'\n", argv[optind]); ttail_init_err: if(dates[0]) { free(dates[0]); } if(dates[1]) { free(dates[1]); }