Writing some tests for LodelHook

Lodel/hooks.py

@@ -43,7 +43,7 @@ class LodelHook(object):
     # @param priority int : the hook priority
     def __init__(self, hook_name, priority = None):
         self._hook_name = hook_name
-        self._priority = 0xFFF if priority is None else priority
+        self._priority = 0xFFFF if priority is None else priority
     
     ## @brief called just after __init__
     # @param hook function : the decorated function
@@ -78,4 +78,10 @@ class LodelHook(object):
         else:
             res = copy.copy(cls._hooks)
         return { name: [(hook._hook, hook._priority) for hook in hooks] for name, hooks in res.items() }
-
+    
+    ## @brief Unregister all hooks
+    # @warning REALLY NOT a good idea !
+    # @note implemented for testing purpose
+    @classmethod
+    def __reset_hooks__(cls):
+        cls._hooks = dict()

Lodel/test/tests_hooks.py

@@ -0,0 +1,112 @@
+#-*- coding: utf-8 -*-
+
+import copy
+import unittest
+from unittest import mock
+from unittest.mock import patch, call, Mock
+
+import leapi.test.utils
+from Lodel.hooks import LodelHook
+
+class LodelHookTestCase(unittest.TestCase):
+
+    #Dynamic code generation & import
+    @classmethod
+    def setUpClass(cls):
+        """ Write the generated code in a temporary directory and import it """
+        cls.tmpdir = leapi.test.utils.tmp_load_factory_code()
+
+    @classmethod
+    def tearDownClass(cls):
+        """ Remove the temporary directory created at class setup """
+        leapi.test.utils.cleanup(cls.tmpdir)
+
+    def test_hook_registration(self):
+        """ Testing hooks registration """
+        self.assertEqual(LodelHook.hook_list('test_hook'), dict())
+        @LodelHook('test_hook', 42)
+        def test_hook(hook_name, caller, payload):
+            pass
+        @LodelHook('test_hook', 1)
+        def test2_hook(hook_name, caller, payload):
+            pass
+        @LodelHook('test_hook')
+        def test3_hook(hook_name, caller, payload):
+            pass
+
+        self.assertEqual(   LodelHook.hook_list('test_hook'),
+                            {
+                                'test_hook':[
+                                    (test2_hook, 1),
+                                    (test_hook, 42),
+                                    (test3_hook, 0xFFFF),
+                                ]
+                            }
+        )
+
+    def test_hook_call(self):
+        """ Testing hooks call """
+        # Registering a mock as hook
+        mockhook = Mock()
+        decorator = LodelHook('test_hook_call')
+        decorator(mockhook)
+        
+        LodelHook.call_hook('test_hook_call', leapi, [1,2,3,42])
+        mockhook.assert_called_once_with('test_hook_call', leapi, [1,2,3,42])
+        mockhook.reset_mock()
+        LodelHook.call_hook('test_hook_call', None, 'datas')
+        mockhook.assert_called_once_with('test_hook_call', None, 'datas')
+
+    def test_leapi_get_hook_leobject(self):
+        """ Testing that leapi_get_* hooks get called when calling get on LeObject """
+        from dyncode import Numero, Article, Publication, Textes, LeRelation, LeObject, LeRelation
+        call_args = {
+                        'query_filters': [],
+                        'offset': 0,
+                        'limit': None,
+                        'order': None,
+                        'group': None,
+                        'field_list': None
+        }
+        for leo in [Numero, Article, Publication, Textes, LeObject]:
+            call_args_full = copy.copy(call_args)
+            if 'instanciate' not in call_args_full:
+                call_args_full['instanciate'] = True
+            if leo.implements_letype():
+                call_args_full['query_filters'].append( ('type_id', '=', leo._type_id) )
+            if leo.implements_leclass():
+                call_args_full['query_filters'].append( ('class_id', '=', leo._class_id) )
+
+            with patch.object(LodelHook, 'call_hook', return_value=call_args_full) as callhook_mock:
+                foo = leo.get(**call_args)
+                expected_calls = [
+                    call('leapi_get_pre', leo, call_args_full),
+                    call('leapi_get_post', leo, None)
+                ]
+                callhook_mock.assert_has_calls(expected_calls, any_order = False)
+
+    def test_leapi_get_hook_lerelation(self):
+        """ Testing that leapi_get_* hooks get called when calling get on LeRelation """
+        from dyncode import LeRelation, LeRel2Type, LeHierarch, RelTextesPersonneAuteur
+        call_args = {
+                        'query_filters': [],
+                        'offset': 0,
+                        'limit': None,
+                        'order': None,
+                        'group': None,
+                        'field_list': None
+        }
+        for lerel in [LeRelation, LeRel2Type, LeHierarch, RelTextesPersonneAuteur]:
+            call_args_full = copy.copy(call_args)
+            if 'instanciate' not in call_args_full:
+                call_args_full['instanciate'] = True
+
+            with patch.object(LodelHook, 'call_hook', return_value=call_args_full) as callhook_mock:
+                foo = lerel.get(**call_args)
+                expected_calls = [
+                    call('leapi_get_pre', lerel, call_args_full),
+                    call('leapi_get_post', lerel, None),
+                ]
+                callhook_mock.assert_has_calls(expected_calls, any_order = False)
+
+    ## @todo Write tests for update, delete and insert hooks

leapi/letype.py

@@ -54,7 +54,14 @@ class _LeType(_LeClass):
     @classmethod
     def get(cls, query_filters, field_list = None, order = None, group = None, limit = None, offset = 0):
         query_filters.append(('type_id', '=', cls._type_id))
-        return super().get(query_filters, field_list, order, group, limit, offset)
+        return super().get(
+                            query_filters = query_filters,
+                            field_list = field_list,
+                            order = order,
+                            group = group,
+                            limit = limit,
+                            offset = offset
+        )
 
     @classmethod
     def fieldtypes(cls, complete=True):