Add tests for LeDeleteQuery Datasource calls

tests/leapi/query/test_datasource.py

@@ -0,0 +1,104 @@
+import unittest
+from unittest import mock
+from unittest.mock import patch
+
+import tests.loader_utils
+from tests.leapi.query.utils import dyncode_module as dyncode
+from lodel.leapi.query import LeDeleteQuery, LeUpdateQuery, LeGetQuery, \
+    LeInsertQuery
+
+class LeQueryDatasourceTestCase(unittest.TestCase):
+    """ Testing LeQuery objects connection with datasource """
+
+    mockread = mock.MagicMock()
+    mockwrite = mock.MagicMock()
+    dyncode = None
+
+    @classmethod
+    def setUpClass(cls):
+        """ Mocking read & write datasource of dyncode """
+        cls.dyncode = dict()
+        for dyncls in dyncode.dynclasses:
+            dyncls._ro_datasource = cls.mockread
+            dyncls._rw_datasource = cls.mockwrite
+            cls.dyncode[dyncls.__name__] = dyncls
+
+    def setUp(self):
+        """ Reseting all mock calls before test """
+        self.mockread.reset_mock()
+        self.mockwrite.reset_mock()
+
+    def check_nocall(self, read = True, exclude = None):
+        """ Utility function to check if a datasource mock method has been
+            called during test """
+        exclude = [] if exclude is None else exclude
+        if read:
+            mockds = self.mockread
+        else:
+            mockds = self.mockwrite
+
+        if 'select' not in exclude:
+            self.assertFalse(
+                mockds.select.called,
+                "select method was not expected to be called")
+        if 'delete' not in exclude:
+            self.assertFalse(
+                mockds.delete.called,
+                "delete method was not expected to be called")
+        if 'update' not in exclude:
+            self.assertFalse(
+                mockds.update.called,
+                "update method was not expected to be called")
+        if 'insert' not in exclude:
+            self.assertFalse(
+                mockds.insert.called,
+                "insert method was not expected to be called")
+
+    def test_delete_simple_filter(self):
+        """ Testing delete query mocking datasource using simple query
+            filters """
+        cls = self.dyncode['Person']
+        query = LeDeleteQuery(
+            target_class = cls,
+            query_filter = ['lodel_id = 1', 'alias.lodel_id = 2'])
+        query.execute()
+        # Cannot check with assert_called_once_with because of the array
+        # that is not in a deterministic order
+        call_args = self.mockwrite.delete.call_args[0]
+        self.assertEqual(call_args[0], cls)
+        self.assertEqual(
+            sorted(call_args[1]),
+            sorted([('lodel_id', '=', '1'), ('alias', '=', '2')]))
+        self.assertEqual(call_args[2], [])
+        self.check_nocall(read = False, exclude = ['delete'])
+        self.check_nocall(read = True)
+
+
+    def test_delete_simple_rel_filters(self):
+        """ Testing delete query mocking datasource using simple filters
+            and relationnal filters"""
+        cls = self.dyncode['Person']
+        query = LeDeleteQuery(
+            target_class = cls,
+            query_filter = ['lodel_id = 1', 'alias.firstname = foo'])
+        query.execute()
+        self.mockwrite.delete.assert_called_once_with(
+            cls,
+            [('lodel_id', '=', '1')],
+            [(('alias', {cls: 'firstname'}), '=', 'foo')])
+        self.check_nocall(read = False, exclude = ['delete'])
+        self.check_nocall(read = True)
+
+    def test_delete_rel_filters(self):
+        """ Testing delete query mocking datasource """
+        cls = self.dyncode['Person']
+        query = LeDeleteQuery(
+            target_class = cls,
+            query_filter = ['alias.firstname = foo'])
+        query.execute()
+        self.mockwrite.delete.assert_called_once_with(
+            cls,
+            [],
+            [(('alias', {cls: 'firstname'}), '=', 'foo')])
+        self.check_nocall(read = False, exclude = ['delete'])
+        self.check_nocall(read = True)

tests/leapi/query/test_filtered.py

@@ -3,7 +3,7 @@ import unittest
 import tests.loader_utils
 from tests.leapi.query.utils import dyncode_module as dyncode
 
-from lodel.leapi.leobject import LeApiDataCheckError
+from lodel.leapi.exceptions import LeApiDataCheckError
 from lodel.leapi.query import LeDeleteQuery, LeUpdateQuery, LeGetQuery
 
 class LeFilteredQueryTestCase(unittest.TestCase):