PEP8

lodel/leapi/datahandlers/data_field.py

@@ -29,8 +29,8 @@ class DataField(FieldDataHandler):
     def check_data_value(self, value):
         if value is None:
             if not self.nullable:
-                return (None, TypeError("'None' value but field is not nullable"))
+                return None, TypeError("'None' value but field is not nullable")
 
-            return (None, None)
+            return None, None
         return super().check_data_value(value)
 

lodel/leapi/datahandlers/data_fields/bool.py

@@ -19,4 +19,4 @@ class DataHandler(DataField):
             value = bool(value)
         except(ValueError, TypeError):
             error = TypeError("The value '%s' is not, and will never, be a boolean" % value)
-        return (value, error)
+        return value, error

lodel/leapi/datahandlers/data_fields/file.py

@@ -11,6 +11,4 @@ class DataHandler(DataField):
     # @param **kwargs
     def __init__(self, upload_path=None, **kwargs):
         self.upload_path = upload_path
-        super().__init__(ftype='file', **kwargs)
-
-
+        super().__init__(**kwargs)

lodel/leapi/datahandlers/data_fields/format.py

@@ -18,11 +18,10 @@ class DataHandler(VarcharDataHandler):
         self._format_string = format_string
         super().__init__(internal='automatic', max_length=max_length)
 
+
     def can_override(self, data_handler):
         if not super().can_override(data_handler):
             return False
-
         if data_handler.max_length != self.max_length:
             return False
-
         return True

lodel/leapi/datahandlers/data_fields/integer.py

@@ -16,5 +16,5 @@ class DataHandler(FieldDataHandler):
             value = int(value)
         except(ValueError, TypeError):
             error = TypeError("The value '%s' is not, and will never, be an integer" % value)
-        return (value, error)
+        return value, error
 

lodel/leapi/datahandlers/data_fields/regexvarchar.py

@@ -23,7 +23,7 @@ class DataHandler(VarcharDataHandler):
         if not self.compiled_re.match(value):
             value = ''
             error = TypeError('"%s" doesn\'t match the regex "%s"' % (value, self.regex))
-        return (value, error)
+        return value, error
 
     def can_override(self, data_handler):
         if not super().can_override(data_handler):

lodel/leapi/datahandlers/data_fields/text.py

@@ -8,9 +8,3 @@ class DataHandler(DataField):
 
     def __init__(self, **kwargs):
         super(self.__class__, self).__init__(ftype='text', **kwargs)
-
-    def can_override(self, data_handler):
-        if data_handler.__class__.base_type != self.__class__.base_type:
-            return False
-        return True
-

lodel/leapi/datahandlers/data_fields/uid.py

@@ -15,4 +15,4 @@ class DataHandler(IntegerDataHandler):
         super(self.__class__, self).__init__(is_id_class=is_id_class, **kwargs)
 
     def _check_data_value(self, value):
-        return (value, None)
+        return value, None

lodel/leapi/datahandlers/data_fields/varchar.py

@@ -13,12 +13,12 @@ class DataHandler(DataField):
         self.max_length = int(max_length)
         super().__init__(**kwargs)
 
+    ## @brief checks if this class can override the given data handler
+    # @param data_handler DataHandler
+    # @return bool
     def can_override(self, data_handler):
-
         if not super().can_override(data_handler):
             return False
-
         if data_handler.max_length != self.max_length:
             return False
-
         return True

lodel/leapi/datahandlers/field_data_handler.py

@@ -11,7 +11,8 @@ class FieldDataHandler(object):
 
     ## @brief constructor
     # @param internal False | str : define whether or not a field is internal
-    # @param immutable bool : indicates if the fieldtype has to be defined in child classes of LeObject or if it is designed globally and immutable
+    # @param immutable bool : indicates if the fieldtype has to be defined in child classes of LeObject or if it is
+    #                         designed globally and immutable
     # @param **args
     # @throw NotImplementedError if it is instanciated directly
     def __init__(self, internal=False, immutable=False, **args):
@@ -41,8 +42,11 @@ class FieldDataHandler(object):
         return self._check_data_value(value)
 
     def _check_data_value(self, value):
-        return (value, None)
+        return value, None
 
+    ## @brief checks if this class can override the given data handler
+    # @param data_handler DataHandler
+    # @return bool
     def can_override(self, data_handler):
         if data_handler.__class__.base_type != self.__class__.base_type:
             return False

lodel/leapi/datahandlers/reference.py

@@ -17,12 +17,13 @@ class Reference(FieldDataHandler):
     def get_relateds(self):
         return self._refs
 
-    ## @brief checks if the target is valid
-
+    ## @brief checks if the data value is valid
+    # @param value
+    # @return
     def check_data_value(self, value):
 
         if not isinstance(value, self._refs_class):
-            return (value, "The reference should be an instance of %s, %s gotten" % (self._refs_class, value.__class__))
+            return value, "The reference should be an instance of %s, %s gotten" % (self._refs_class, value.__class__)
 
         if isinstance(value, EmClass):
             value = [value]
@@ -32,6 +33,6 @@ class Reference(FieldDataHandler):
 
         for related in value:
             if not isinstance(related, EmClass):
-                return (value, "The reference %s should be an instance of EmClass, %s gotten" % (related.display_name, related.__class__))
-
-        return (value, None)
+                return value, "The reference %s should be an instance of EmClass, %s gotten" % (related.display_name,
+                                                                                                related.__class__)
+        return value, None

lodel/leapi/datahandlers/references/dict.py

@@ -9,7 +9,7 @@ class DataHandler(Reference):
     # @param allowed_classes list | None : list of allowed em classes if None no restriction
     # @param internal bool : if False, the field is not internal
     # @param kwargs : Other named arguments
-    def __init__(self, allowed_classes = None, internal=False, **kwargs):
+    def __init__(self, allowed_classes=None, internal=False, **kwargs):
         super().__init__(allowed_classes=allowed_classes, internal=internal, **kwargs)
 
     ## @brief checks if the given target is valid

lodel/leapi/datahandlers/references/link.py

@@ -9,5 +9,5 @@ class DataHandler(Reference):
     # @param allowed_classes list | None : list of allowed em classes if None no restriction
     # @param internal bool : if False, the field is not internal
     # @param kwargs : Other named arguments
-    def __init__(self, allowed_classes = None, internal=False, **kwargs):
+    def __init__(self, allowed_classes=None, internal=False, **kwargs):
         super().__init__(allowed_classes=allowed_classes, internal=internal, **kwargs)

lodel/leapi/datahandlers/references/list.py

@@ -9,7 +9,7 @@ class DataHandler(Reference):
     # @param allowed_classes list | None : list of allowed em classes if None no restriction
     # @param internal bool
     # @param kwargs
-    def __init__(self, allowed_classes = None, internal=False, **kwargs):
+    def __init__(self, allowed_classes=None, internal=False, **kwargs):
         super().__init__(allowed_classes=allowed_classes, internal=internal, **kwargs)
 
     ## @brief adds a referenced element

lodel/leapi/datahandlers/references/set.py

@@ -9,7 +9,7 @@ class DataHandler(Reference):
     # @param allowed_classes list | None : list of allowed em classes if None no restriction
     # @param internal bool : if False, the field is not internal
     # @param kwargs : Other named arguments
-    def __init__(self, allowed_classes = None, internal=False, **kwargs):
+    def __init__(self, allowed_classes=None, internal=False, **kwargs):
         super().__init__(allowed_classes=allowed_classes, internal=internal, **kwargs)
 
     ## @brief adds a referenced element

lodel/utils/mlstring.py

@@ -1,9 +1,10 @@
 #-*- coding: utf-8 -*-
 
-import hashlib
 import copy
+import hashlib
 import json
 
+
 ## @brief Stores multilangage string
 class MlString(object):
     
@@ -41,7 +42,7 @@ class MlString(object):
         elif lang in self.values:
             return self.values[lang]
         else:
-           return str(self)
+            return str(self)
 
     ## @brief Set a translation
     # @param lang str : the lang
@@ -103,4 +104,3 @@ class MlString(object):
 
     def __repr__(self):
         return repr(self.values)
-