Bufix on LeObject.update + test

lodel/leapi/leobject.py

@@ -268,8 +268,8 @@ raised when trying to import Datasource"
     
     ##@brief Read only access to all datas
     #@return a dict representing datas of current instance
-    def datas(self):
-        return [self.data(fname) for fname in self.fieldnames(True)]
+    def datas(self, internal = False):
+        return {fname:self.data(fname) for fname in self.fieldnames(internal)}
         
     
     ##@brief Datas setter
@@ -485,7 +485,7 @@ raised when trying to import Datasource"
     ## @brief Update an instance of LeObject
     #
     #@param datas : list of new datas 
-    def update(self, datas):
+    def update(self, datas = None):
         datas = self.datas(internal=False) if datas is None else datas
         uids = self._uid
         query_filter = list()
@@ -493,7 +493,7 @@ raised when trying to import Datasource"
             query_filter.append((uid, '=', self.data(uid)))
         
         try:
-            query = LeUpdateQuery(cls, query_filter)
+            query = LeUpdateQuery(self.__class__, query_filter)
         except Exception as err:
             raise err
             

tests/leapi/test_leobject.py

@@ -171,3 +171,21 @@ class LeObjectQueryMockTestCase(unittest.TestCase):
             dyncode.Person.delete_bundle(['lodel_id > 1'])
             mock_execute.assert_called_once_with()
 
+    def test_update_instance(self):
+        """ Checking that LeObject update method calls LeUpdateQuery
+            correctly """
+        with patch.object(
+            LeUpdateQuery, '__init__', return_value = None) as mock_init:
+            with patch.object(
+                LeObject, 'datas', return_value = {
+                    'lodel_id': 1, 'firstname': 'foo', 'lastname': 'bar',
+                    'fullname': 'Foo Bar', 'alias': None }) as mock_datas:
+            
+                inst = dyncode.Person(
+                    lodel_id = 1, firstname = "foo", lastname = "bar")
+                try:
+                   inst.update()
+                except AttributeError:
+                    pass
+                mock_init.assert_called_once_with(
+                    dyncode.Person, [('lodel_id', '=', 1)])