Settings started detection mechanism enhancement + early log message creation (for plugins & settings)

lodel/plugin/plugins.py

@@ -157,6 +157,8 @@ to generic PluginVersion comparison function : '%s'" % cmp_fun_name)
 # 1. Settings call start method to instanciate all plugins found in confs
 # 2. Settings fetch all confspecs
 # 3. the loader call load_all to register hooks etc
+#
+#@todo add log messages (now we can)
 class Plugin(object):
     
     ##@brief Stores plugin directories paths
@@ -438,6 +440,7 @@ name differ from the one found in plugin's init file"
             raise PluginError(msg)
         plugin = cls(plugin_name)
         cls._plugin_instances[plugin_name] = plugin
+        logger.debug("Plugin %s available." % plugin)
         return plugin
 
     ##@brief Plugins instances accessor

lodel/settings/settings.py

@@ -68,6 +68,7 @@ class MetaSettings(type):
 # '.*')
 # @todo delete the first stage, the lib path HAVE TO BE HARDCODED. In fact
 #when we will run lodel in production the lodel2 lib will be in the python path
+#@todo add log messages (now we can)
 class Settings(object, metaclass=MetaSettings):
 
     ## @brief Stores the singleton instance
@@ -85,6 +86,7 @@ class Settings(object, metaclass=MetaSettings):
         ## @brief Stores the configurations in namedtuple tree
         self.__confs = None
         self.__conf_dir = conf_dir
+        self.__started = False
         self.__bootstrap()
     
     ## @brief Get the named tuple representing configuration
@@ -100,7 +102,7 @@ class Settings(object, metaclass=MetaSettings):
 
     @classmethod
     def started(cls):
-        return cls.instance is not None and cls.instance.__confs is not None
+        return cls.instance is not None and cls.instance.__started
 
     ##@brief An utility method that raises if the singleton is not in a good
     # state
@@ -128,6 +130,7 @@ class Settings(object, metaclass=MetaSettings):
 
     ##@brief This method handlers Settings instance bootstraping
     def __bootstrap(self):
+        logger.debug("Settings bootstraping")
         lodel2_specs = LODEL2_CONF_SPECS
         for section in lodel2_specs:
             if section.lower() != section:
@@ -154,6 +157,7 @@ class Settings(object, metaclass=MetaSettings):
                                             plugins_path_opt_specs[0],
                                             False)
         # Starting the Plugins class
+        logger.debug("Starting lodel.plugin.Plugin class")
         Plugin.start(plugins_path, plugins_list)
         # Fetching conf specs from plugins
         specs = [lodel2_specs]
@@ -167,6 +171,7 @@ class Settings(object, metaclass=MetaSettings):
             raise SettingsErrors(errors)
         self.__conf_specs = self.__merge_specs(specs)
         self.__populate_from_specs(self.__conf_specs, loader)
+        self.__started = True
     
     ##@brief Produce a configuration specification dict by merging all specifications
     #

lodel/settings/settings_loader.py

@@ -4,6 +4,7 @@ import os
 import glob
 import copy
 
+from lodel import logger
 from lodel.settings.utils import *
 from lodel.settings.validator import SettingsValidationError
 from lodel.settings.utils import SettingsError, SettingsErrors
@@ -32,7 +33,9 @@ class SettingsLoader(object):
     # @return dict()
     def __merge(self):
         conf = dict()
-        l_dir = glob.glob(self.__conf_path+'/*.ini')  
+        l_dir = glob.glob(self.__conf_path+'/*.ini')
+        logger.debug("SettingsLoader found those settings files : %s" % (
+            ', '.join(l_dir)))
 
         for f_ini in l_dir:  
             config = configparser.ConfigParser(default_section = self.DEFAULT_SECTION ,interpolation=None)
@@ -86,6 +89,8 @@ class SettingsLoader(object):
             sec[keyname]['value'] = default_value
             sec[keyname]['file'] = SettingsLoader.DEFAULT_FILENAME
             result = default_value
+            logger.debug("Using default value for configuration key %s:%s" % (
+                section, keyname))
 
         try:
             return validator(result)