Enhancement in build + bugfixes

src/Makefile.am

@@ -1,5 +1,6 @@
 bin_PROGRAMS = asmsh child
 
+noinst_PROGRAMS = child
 noinst_LIBRARIES= libcheck_asmsh.a
 
 libcheck_asmsh_a_SOURCES = mmap_parse.c asm_env.c breakpoints.c compile.c logger.c \
@@ -7,13 +8,18 @@ libcheck_asmsh_a_SOURCES = mmap_parse.c asm_env.c breakpoints.c compile.c logger
 			   shell.c shell_cmds.c shell_sym.c \
 			   shell_cmd_breakpoint.c
 
+noinst_HEADERS = asmsh.h mmap_parse.h asm_env.h breakpoints.h compile.h logger.h \
+		completion.h history.h \
+		shell.h shell_cmds.h shell_sym.h syscalls.h
+
+
 asmsh_SOURCES = asmsh.c $(libcheck_asmsh_a_SOURCES)
 child_SOURCES = child.s
 
 asmsh_LDADD=child_bin.o
 asmsh_LDFLAGS=-g -O2
 
-AM_CFLAGS=-Wall -Werror
+AM_CFLAGS=-Wall -Werror -fstack-protector-strong -Wformat -Werror=format-security
 AM_CCASFLAGS=-g -O0
 child_LDFLAGS=-nostdlib
 

src/shell_cmds.c

@@ -314,7 +314,7 @@ int asmsh_cmd_syscalls(asmsh_t *sh, asmsh_cmd_args_t *args)
 			printf("\n");
 			printed = ret;
 		}
-		printf(buf);
+		printf("%s", buf);
 	}
 	printf("\n");
 	return 0;
@@ -382,7 +382,7 @@ int asmsh_cmd_help_(asmsh_t *sh, asmsh_cmd_args_t *args)
 		ret += snprintf(buf+ret, 4096-ret, "  %-18s : %s\n", 
 				abuf, cmd->desc);
 	}
-	dprintf(2, buf);
+	dprintf(2, "%s", buf);
 	return 0;
 }
 

tests/samples/Makefile.am

@@ -1,6 +1,8 @@
 if CHECK
 bin_PROGRAMS = asm_env_stamps
 
+EXTRA_DIST=procfs_pid_maps procfs_pid_maps_sm sample.history
+
 asm_env_stamps_SOURCES = asm_env_stamps.s
 asm_env_stamps_CCASFLAGS = -g -O0
 

tests/tests_history.c

@@ -41,7 +41,7 @@ END_TEST
 START_TEST(test_save)
 {
 	// Do not test the written content, only check for segfaults
-	const char * const hist[]={"foo", "bar", "super history"};
+	const char * const hist[]={"foo", "bar", "super history", NULL};
 	save_history("/dev/null", hist);
 
 }