Better error handling

asm_env.c

@@ -68,7 +68,10 @@ asmsh_env_t* asmsh_env(const char *childpath)
 
 	return res;
 err:
-	free(res->childpath);
+	if(res->childpath)
+	{
+		free(res->childpath);
+	}
 err_pathdup:
 	free(res);
 	errno = err;
@@ -266,6 +269,11 @@ static int _asmsh_env_spawn(asmsh_env_t *env)
 
 	const char *childpath = env->childpath?env->childpath:asmsh_env_tmpexec();
 
+	if(!childpath)
+	{
+		return -1; // Error in asmsh_env_tmpexec()
+	}
+
 	if((env->pid = fork()) == -1)
 	{
 		err = errno;
@@ -422,7 +430,17 @@ static void _asmsh_env_child(const char *childpath)
 static char *asmsh_env_tmpexec()
 {
 	char *ret = strdup("asmsh_child_XXXXXXXXX");
+	if(!ret)
+	{
+		perror("getting a temporary file name");
+		return NULL;
+	}
 	int tmpfd = mkstemp(ret);
+	if(tmpfd < 0)
+	{
+		perror("Unable to mk temporary file");
+		return NULL;
+	}
 	const int sz = &_binary_child_end - &_binary_child_start;
 	int rsz = write(tmpfd, &_binary_child_start, sz);
 	if(rsz<sz)