Bugfixing a buffer overflow on PID fmt field

This overflow was avoided using the volatile i

configure.ac

@@ -14,8 +14,6 @@ AC_USE_SYSTEM_EXTENSIONS
 AC_GNU_SOURCE
 
 # Checks for programs.
-AC_PROG_CC
-AC_PROG_RANLIB
 
 AC_ARG_VAR(PYTHON_CONFIG_PATH, [python3-config path])
 AC_PATH_PROG(PYTHON_CONFIG_PATH, [python3-config], [no])
@@ -36,10 +34,14 @@ fi
 
 if test x"${enable_debug}" = x"yes"; then
 	AM_CFLAGS="-Wall -g -DDEBUG"
+	CFLAGS="-O0"
 else
 	AM_CFLAGS="-Wall -Werror -O2"
 fi
 
+AC_PROG_CC
+AC_PROG_RANLIB
+
 AC_ENABLE_SHARED
 AC_DISABLE_STATIC
 AC_PROG_LIBTOOL

include/logger.h

@@ -65,7 +65,7 @@
 #define PYFCGI_LOG_DTM_LEN 25
 #define PYFCGI_LOG_LVL_LEN 7
 #define PYFCGI_LOG_TYP_LEN 7
-#define PYFCGI_LOG_PID_LEN 6
+#define PYFCGI_LOG_PID_LEN 7
 #define PYFCGI_LOG_PID_FMT "%6d"
 
 #define SYSLOG_syslog syslog

include/python_pyfcgi.h

@@ -92,7 +92,7 @@ extern PyMethodDef pyfcgimodule_methods[];
 extern PyModuleDef pyfcgimodule;
 
 /**@brief Clean response_status & response_headers globals */
-inline void libpyfcgi_clean_response()
+static inline void libpyfcgi_clean_response()
 {
 	if(libpyfcgi.status) { Py_DECREF(libpyfcgi.status); }
 	libpyfcgi.status = NULL;

src/logger.c

@@ -237,7 +237,7 @@ exit_err:
 
 int pyfcgi_logger_format_bufinit(pyfcgi_logger_format_t* fmt)
 {
-	volatile unsigned short i;
+	unsigned int i;
 	size_t pre_sz, suf_sz;
 	char *cur, pid[PYFCGI_LOG_PID_LEN];
 	fmt->buf = fmt->prefix = fmt->suffix = NULL;
@@ -320,7 +320,7 @@ int pyfcgi_logger_format_bufinit(pyfcgi_logger_format_t* fmt)
 						fmt->fields[i].len);
 					break;
 				case pyfcgi_logger_field_pid:
-					snprintf(pid, PYFCGI_LOG_PID_LEN+1,
+					snprintf(pid, PYFCGI_LOG_PID_LEN,
 						PYFCGI_LOG_PID_FMT,
 						*((pid_t*)fmt->fields[i].val));
 					memcpy(cur, pid, PYFCGI_LOG_PID_LEN);
@@ -337,6 +337,10 @@ int pyfcgi_logger_format_bufinit(pyfcgi_logger_format_t* fmt)
 			cur = fmt->suffix;
 			i++;
 		}
+		else
+		{
+			break;
+		}
 	}
 	return 0;
 }
@@ -427,7 +431,7 @@ int pyfcgi_logger_parse_field(const char** ptr, const char *start,
 			cur_field->val = (void*)pyfcgi_logger_value_facility;
 			break;
 		case pyfcgi_logger_field_pid:
-			default_len = PYFCGI_LOG_PID_LEN;
+			default_len = PYFCGI_LOG_PID_LEN-1;
 			cur_field->val = &(PyFCGI_conf.context.pid);
 			break;
 		case pyfcgi_logger_field_ident: