Fix for #435

api.php

@@ -184,7 +184,6 @@ class TempFileCache implements Cache
         $s = DIRECTORY_SEPARATOR;
         $ps = PATH_SEPARATOR;
         if ($config == '') {
-            $id = substr(md5(__FILE__), 0, 8);
             $this->path = sys_get_temp_dir() . $s . $prefix . self::SUFFIX;
         } elseif (strpos($config, $ps) === false) {
             $this->path = $config;
@@ -630,7 +629,7 @@ class ReflectedTable implements \JsonSerializable
         return $this->pk != null;
     }
 
-    public function getPk(): ReflectedColumn
+    public function getPk() /*: ?ReflectedColumn */
     {
         return $this->pk;
     }
@@ -1917,6 +1916,9 @@ class GenericDB
         if ($limit == 0) {
             return array();
         }
+        if (!$columnOrdering) {
+            return $this->selectAllUnordered($table, $columnNames, $condition);
+        }
         $selectColumns = $this->columns->getSelect($table, $columnNames);
         $tableName = $table->getName();
         $condition = $this->addAuthorizationCondition($condition);
@@ -3825,7 +3827,10 @@ class OrderingInfo
             }
         }
         if (count($fields) == 0) {
-            $fields[] = [$table->getPk()->getName(), 'ASC'];
+            $pk = $table->getPk();
+            if ($pk) {
+                $fields[] = [$pk->getName(), 'ASC'];
+            }
         }
         return $fields;
     }

src/Tqdev/PhpCrudApi/Column/Reflection/ReflectedTable.php

@@ -84,7 +84,7 @@ class ReflectedTable implements \JsonSerializable
         return $this->pk != null;
     }
 
-    public function getPk(): ReflectedColumn
+    public function getPk() /*: ?ReflectedColumn */
     {
         return $this->pk;
     }

src/Tqdev/PhpCrudApi/Database/GenericDB.php

@@ -192,6 +192,9 @@ class GenericDB
         if ($limit == 0) {
             return array();
         }
+        if (!$columnOrdering) {
+            return $this->selectAllUnordered($table, $columnNames, $condition);
+        }
         $selectColumns = $this->columns->getSelect($table, $columnNames);
         $tableName = $table->getName();
         $condition = $this->addAuthorizationCondition($condition);

src/Tqdev/PhpCrudApi/Record/OrderingInfo.php

@@ -26,7 +26,10 @@ class OrderingInfo
             }
         }
         if (count($fields) == 0) {
-            $fields[] = [$table->getPk()->getName(), 'ASC'];
+            $pk = $table->getPk();
+            if ($pk) {
+                $fields[] = [$pk->getName(), 'ASC'];
+            }
         }
         return $fields;
     }

tests/fixtures/blog_mysql.sql

@@ -169,6 +169,14 @@ CREATE TABLE `invisibles` (
 INSERT INTO `invisibles` (`id`) VALUES
 ('e42c77c6-06a4-4502-816c-d112c7142e6d');
 
+DROP TABLE IF EXISTS `nopk`;
+CREATE TABLE `nopk` (
+  `id` varchar(36) NOT NULL
+) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_general_ci;
+
+INSERT INTO `nopk` (`id`) VALUES
+('e42c77c6-06a4-4502-816c-d112c7142e6d');
+
 SET foreign_key_checks = 1;
 
 -- 2016-11-05 13:11:47

tests/fixtures/blog_pgsql.sql

@@ -32,6 +32,7 @@ DROP TABLE IF EXISTS barcodes CASCADE;
 DROP TABLE IF EXISTS barcodes2 CASCADE;
 DROP TABLE IF EXISTS "kunsthåndværk" CASCADE;
 DROP TABLE IF EXISTS invisibles CASCADE;
+DROP TABLE IF EXISTS nopk CASCADE;
 
 --
 -- Name: categories; Type: TABLE; Schema: public; Owner: postgres; Tablespace:
@@ -169,6 +170,14 @@ CREATE TABLE "invisibles" (
   id character varying(36) NOT NULL
 );
 
+--
+-- Name: nopk; Type: TABLE; Schema: public; Owner: postgres; Tablespace:
+--
+
+CREATE TABLE "nopk" (
+  id character varying(36) NOT NULL
+);
+
 --
 -- Data for Name: categories; Type: TABLE DATA; Schema: public; Owner: postgres
 --
@@ -264,6 +273,13 @@ INSERT INTO "kunsthåndværk" ("id", "Umlauts ä_ö_ü-COUNT", "invisible") VALU
 INSERT INTO "invisibles" ("id") VALUES
 ('e42c77c6-06a4-4502-816c-d112c7142e6d');
 
+--
+-- Data for Name: nopk; Type: TABLE DATA; Schema: public; Owner: postgres
+--
+
+INSERT INTO "nopk" ("id") VALUES
+('e42c77c6-06a4-4502-816c-d112c7142e6d');
+
 --
 -- Name: categories_pkey; Type: CONSTRAINT; Schema: public; Owner: postgres; Tablespace:
 --

tests/fixtures/blog_sqlsrv.sql

@@ -118,6 +118,12 @@ DROP TABLE [invisibles]
 END
 GO
 
+IF (OBJECT_ID('nopk', 'U') IS NOT NULL)
+BEGIN
+DROP TABLE [nopk]
+END
+GO
+
 CREATE TABLE [categories](
 	[id] [int] IDENTITY,
 	[name] [nvarchar](255) NOT NULL,
@@ -231,6 +237,11 @@ CREATE TABLE [invisibles](
 )
 GO
 
+CREATE TABLE [nopk](
+	[id] [nvarchar](36)
+)
+GO
+
 INSERT [categories] ([name], [icon]) VALUES (N'announcement', NULL)
 GO
 INSERT [categories] ([name], [icon]) VALUES (N'article', NULL)
@@ -289,6 +300,9 @@ GO
 INSERT [invisibles] ([id]) VALUES ('e42c77c6-06a4-4502-816c-d112c7142e6d')
 GO
 
+INSERT [nopk] ([id]) VALUES ('e42c77c6-06a4-4502-816c-d112c7142e6d')
+GO
+
 ALTER TABLE [comments]  WITH CHECK ADD 	CONSTRAINT [FK_comments_posts] FOREIGN KEY([post_id])
 REFERENCES [posts] ([id])
 GO

tests/functional/001_records/072_list_nopk.log

@@ -0,0 +1,7 @@
+GET /records/nopk
+===
+200
+Content-Type: application/json
+Content-Length: 59
+
+{"records":[{"id":"e42c77c6-06a4-4502-816c-d112c7142e6d"}]}

tests/functional/002_columns/001_get_database.log

@@ -2,6 +2,6 @@ GET /columns
 ===
 200
 Content-Type: application/json
-Content-Length: 2153
+Content-Length: 2224
 
-{"name":"php-crud-api","tables":[{"name":"barcodes","columns":[{"name":"id","type":"integer","pk":true},{"name":"product_id","type":"integer","fk":"products"},{"name":"hex","type":"varchar","length":255},{"name":"bin","type":"blob"}]},{"name":"categories","columns":[{"name":"id","type":"integer","pk":true},{"name":"name","type":"varchar","length":255},{"name":"icon","type":"blob","nullable":true}]},{"name":"comments","columns":[{"name":"id","type":"integer","pk":true},{"name":"post_id","type":"integer","fk":"posts"},{"name":"message","type":"varchar","length":255}]},{"name":"countries","columns":[{"name":"id","type":"integer","pk":true},{"name":"name","type":"varchar","length":255},{"name":"shape","type":"geometry"}]},{"name":"events","columns":[{"name":"id","type":"integer","pk":true},{"name":"name","type":"varchar","length":255},{"name":"datetime","type":"timestamp"},{"name":"visitors","type":"integer"}]},{"name":"kunsthåndværk","columns":[{"name":"id","type":"varchar","length":36,"pk":true},{"name":"Umlauts ä_ö_ü-COUNT","type":"integer"}]},{"name":"post_tags","columns":[{"name":"id","type":"integer","pk":true},{"name":"post_id","type":"integer","fk":"posts"},{"name":"tag_id","type":"integer","fk":"tags"}]},{"name":"posts","columns":[{"name":"id","type":"integer","pk":true},{"name":"user_id","type":"integer","fk":"users"},{"name":"category_id","type":"integer","fk":"categories"},{"name":"content","type":"varchar","length":255}]},{"name":"products","columns":[{"name":"id","type":"integer","pk":true},{"name":"name","type":"varchar","length":255},{"name":"price","type":"decimal","precision":10,"scale":2},{"name":"properties","type":"clob"},{"name":"created_at","type":"timestamp"},{"name":"deleted_at","type":"timestamp","nullable":true}]},{"name":"tags","columns":[{"name":"id","type":"integer","pk":true},{"name":"name","type":"varchar","length":255},{"name":"is_important","type":"boolean"}]},{"name":"users","columns":[{"name":"id","type":"integer","pk":true},{"name":"username","type":"varchar","length":255},{"name":"password","type":"varchar","length":255},{"name":"location","type":"geometry","nullable":true}]}]}
+{"name":"php-crud-api","tables":[{"name":"barcodes","columns":[{"name":"id","type":"integer","pk":true},{"name":"product_id","type":"integer","fk":"products"},{"name":"hex","type":"varchar","length":255},{"name":"bin","type":"blob"}]},{"name":"categories","columns":[{"name":"id","type":"integer","pk":true},{"name":"name","type":"varchar","length":255},{"name":"icon","type":"blob","nullable":true}]},{"name":"comments","columns":[{"name":"id","type":"integer","pk":true},{"name":"post_id","type":"integer","fk":"posts"},{"name":"message","type":"varchar","length":255}]},{"name":"countries","columns":[{"name":"id","type":"integer","pk":true},{"name":"name","type":"varchar","length":255},{"name":"shape","type":"geometry"}]},{"name":"events","columns":[{"name":"id","type":"integer","pk":true},{"name":"name","type":"varchar","length":255},{"name":"datetime","type":"timestamp"},{"name":"visitors","type":"integer"}]},{"name":"kunsthåndværk","columns":[{"name":"id","type":"varchar","length":36,"pk":true},{"name":"Umlauts ä_ö_ü-COUNT","type":"integer"}]},{"name":"nopk","columns":[{"name":"id","type":"varchar","length":36}]},{"name":"post_tags","columns":[{"name":"id","type":"integer","pk":true},{"name":"post_id","type":"integer","fk":"posts"},{"name":"tag_id","type":"integer","fk":"tags"}]},{"name":"posts","columns":[{"name":"id","type":"integer","pk":true},{"name":"user_id","type":"integer","fk":"users"},{"name":"category_id","type":"integer","fk":"categories"},{"name":"content","type":"varchar","length":255}]},{"name":"products","columns":[{"name":"id","type":"integer","pk":true},{"name":"name","type":"varchar","length":255},{"name":"price","type":"decimal","precision":10,"scale":2},{"name":"properties","type":"clob"},{"name":"created_at","type":"timestamp"},{"name":"deleted_at","type":"timestamp","nullable":true}]},{"name":"tags","columns":[{"name":"id","type":"integer","pk":true},{"name":"name","type":"varchar","length":255},{"name":"is_important","type":"boolean"}]},{"name":"users","columns":[{"name":"id","type":"integer","pk":true},{"name":"username","type":"varchar","length":255},{"name":"password","type":"varchar","length":255},{"name":"location","type":"geometry","nullable":true}]}]}