Quellcode durchsuchen

[models/variable_value] lint code

Maxime Alves LIRMM@home vor 3 Jahren
Ursprung
Commit
d16554a59f
1 geänderte Dateien mit 3 neuen und 8 gelöschten Zeilen
  1. 3
    8
      pyheatpump/models/variable_value.py

+ 3
- 8
pyheatpump/models/variable_value.py Datei anzeigen

1
 from pyheatpump.db import DB, RowClass
1
 from pyheatpump.db import DB, RowClass
2
 from datetime import datetime
2
 from datetime import datetime
3
-from pprint import pprint
4
 
3
 
5
 from .variable_type import VariableType
4
 from .variable_type import VariableType
6
 from pyheatpump.logger import logger_init
5
 from pyheatpump.logger import logger_init
15
     value: int = None
14
     value: int = None
16
 
15
 
17
     def __init__(self, **kwargs):
16
     def __init__(self, **kwargs):
18
-        logger.debug("""Create VariableValue object with attributes\n
19
-        :type:{}
20
-        :address:{}
21
-        :value:{}""".format(*kwargs.values()))
22
-        if 'type' in kwargs.keys() and type(kwargs['type']) != VariableType:
17
+        if 'type' in kwargs.keys() and isinstance(kwargs['type'], VariableType):
23
             kwargs['type'] = VariableType.get(kwargs['type'])
18
             kwargs['type'] = VariableType.get(kwargs['type'])
24
 
19
 
25
 
20
 
70
         return self.insert()
65
         return self.insert()
71
 
66
 
72
     @staticmethod
67
     @staticmethod
73
-    def get(type, address, time=datetime.now()):
68
+    def get(var_type, address, time=datetime.now()):
74
         try:
69
         try:
75
             row = next(DB.sql(
70
             row = next(DB.sql(
76
             """SELECT * FROM var_value
71
             """SELECT * FROM var_value
80
                 AND time <= :time
75
                 AND time <= :time
81
             ORDER BY time DESC
76
             ORDER BY time DESC
82
             LIMIT 1""", {
77
             LIMIT 1""", {
83
-                'type':str(type), 'address':address, 'time':int(time.strftime('%s'))+1
78
+                'type':str(var_type), 'address':address, 'time':int(time.strftime('%s'))+1
84
             }))
79
             }))
85
             return VariableValue(**dict(row))
80
             return VariableValue(**dict(row))
86
         except StopIteration as e:
81
         except StopIteration as e:

Laden…
Abbrechen
Speichern