Browse Source

[modbus] clean logs

Maxime Alves LIRMM@home 3 years ago
parent
commit
3f142af51b
1 changed files with 15 additions and 11 deletions
  1. 15
    11
      pyheatpump/modbus.py

+ 15
- 11
pyheatpump/modbus.py View File

@@ -46,9 +46,7 @@ def read_coils(start, end):
46 46
     address = -1
47 47
     qty = -1
48 48
 
49
-    logger.info('Read coils [{}, {}]'.format(
50
-        start, end
51
-    ))
49
+    logger.info('read_coils: [%s, %s]', start, end)
52 50
     try:
53 51
         for address in range(start, end + 1, 125):
54 52
             qty = 125 if (end - address) >= 125 else (end - address)
@@ -66,6 +64,7 @@ def read_coils(start, end):
66 64
         print(e)
67 65
         print(f'{address} {qty}')
68 66
 
67
+    logger.debug('read_coils [%s, %s] result: %s', start, end, res)
69 68
     return res
70 69
 
71 70
 
@@ -78,9 +77,9 @@ def read_holding_registers(start, end):
78 77
     address = -1
79 78
     qty = -1
80 79
 
81
-    logger.info('Read registers [{}, {}]'.format(
80
+    logger.debug('read_holding_registers [%s, %s]',
82 81
         start, end
83
-    ))
82
+    )
84 83
 
85 84
     try:
86 85
         for address in range(start, end + 1, 125):
@@ -99,15 +98,16 @@ def read_holding_registers(start, end):
99 98
         print(e)
100 99
         print(f'{address} {qty}')
101 100
 
101
+    logger.debug('read_holding_registers [%s, %s] result: %s', start, end, res)
102 102
     return res
103 103
 
104 104
 def write_coil(var_value):
105 105
     global serial_conn
106 106
     connect()
107 107
 
108
-    logger.info('Write coil at address {} with value {}]'.format(
108
+    logger.debug('write_coil address: %s, value: %s',
109 109
         var_value.address, var_value.value
110
-    ))
110
+    )
111 111
 
112 112
     try:
113 113
         req_adu = rtu.write_single_coil(
@@ -115,7 +115,10 @@ def write_coil(var_value):
115 115
             address=var_value.address,
116 116
             value=var_value.value)
117 117
         resp = rtu.send_message(req_adu, serial_conn)
118
-        logger.info('Modbus response : {}'.format(resp))
118
+
119
+        logger.debug('write_coil address: %s, response: %s',
120
+                var_value.address, resp)
121
+
119 122
         if resp != var_value.value:
120 123
             return False
121 124
         return True
@@ -127,9 +130,9 @@ def write_holding_register(var_value):
127 130
     global serial_conn
128 131
     connect()
129 132
 
130
-    logger.info('Write register at address {} with value {}]'.format(
133
+    logger.debug('write_holding_register address: %s, value: %s',
131 134
         var_value.address, var_value.value
132
-    ))
135
+    )
133 136
 
134 137
     try:
135 138
         req_adu = rtu.write_single_register(
@@ -137,7 +140,8 @@ def write_holding_register(var_value):
137 140
             address=var_value.address,
138 141
             value=var_value.value)
139 142
         resp = rtu.send_message(req_adu, serial_conn)
140
-        logger.info('Modbus response : {}'.format(resp))
143
+        logger.debug('write_holding_register, addres: %s, response: %s',
144
+                var_value.address, resp)
141 145
         if resp != var_value.value:
142 146
             return False
143 147
         return True

Loading…
Cancel
Save