test: ajout test méthode update

Gemfile

@@ -33,7 +33,7 @@ group :development, :test do
   # Call 'byebug' anywhere in the code to stop execution and get a debugger console
   # gem 'byebug', platforms: [:mri, :mingw, :x64_mingw]
   gem 'pry'
-  gem 'pry-rails'
+  # gem 'pry-rails'
 end
 
 group :development do

Gemfile.lock

@@ -108,8 +108,6 @@ GEM
     pry (0.14.1)
       coderay (~> 1.1)
       method_source (~> 1.0)
-    pry-rails (0.3.9)
-      pry (>= 0.10.4)
     puma (5.2.2)
       nio4r (~> 2.0)
     racc (1.5.2)
@@ -188,7 +186,6 @@ DEPENDENCIES
   listen (~> 3.3)
   pg
   pry
-  pry-rails
   puma (~> 5.0)
   rack-cors
   rails (~> 6.1.3, >= 6.1.3.1)

app/controllers/api/v1/memberships_controller.rb

@@ -24,13 +24,17 @@ class Api::V1::MembershipsController < ApplicationController
   end
 
   def update
-    if @membership.update(memberships_params)
-      render json: MembershipSerializer.new(@membership).serializable_hash.to_json, status: :ok
+    if params[:membership][:can_edit] 
+      if @membership.update(memberships_params)
+        render json: MembershipSerializer.new(@membership).serializable_hash.to_json, status: :ok
+      else
+        render json: @membership.errors, status: :unprocessable_entity
+      end
     else
-      render json: @membership.errors, status: :unprocessable_entity
+      head 422
     end
   end
-
+  
   def destroy
     @membership.destroy
     head 204

test/controllers/api/v1/memberships_controller_test.rb

@@ -73,21 +73,13 @@ class Api::V1::MembershipsControllerTest < ActionDispatch::IntegrationTest
     assert_response :forbidden
   end
 
-  # test "should forbid update read_only attributes - team_id" do
-  #   patch api_v1_membership_url(@membership),
-  #   headers: { Authorization: JsonWebToken.encode(user_id: @user.id) }, 
-  #   params: { membership: { team_id: @team2.id } },
-  #   as: :json
-  #   assert_response :unprocessable_entity
-  # end
-
-  # test "should forbid update read_only attributes - member_id" do
-  #   patch api_v1_membership_url(@membership),
-  #   headers: { Authorization: JsonWebToken.encode(user_id: @user.id) }, 
-  #   params: { membership: { member_id: @user2.id } },
-  #   as: :json
-  #   assert_response :unprocessable_entity
-  # end  
+  test "should forbid update read_only attributes - team_id" do
+    patch api_v1_membership_url(@membership),
+    headers: { Authorization: JsonWebToken.encode(user_id: @user.id) }, 
+    params: { membership: { team_id: @team2.id, member_id: @user2.id } },
+    as: :json
+    assert_response :unprocessable_entity
+  end
 
   # DESTROY
   test "should destroy membership" do

test/models/membership_test.rb

@@ -29,8 +29,4 @@ class MembershipTest < ActiveSupport::TestCase
     membership = Membership.new(member_id: @user.id, team_id: @team.id, can_edit: true)
     assert_not membership.valid?
   end
-
-  test "membership team & member id should not be updated" do
-    # How to perfom this test ?
-  end
 end